---
name: engineering-review
description: Run a structured engineering review against specialty checklists — automation contracts, runtime safety, frontend UI, security, or architecture. Use this skill whenever code is ready for review, before merging PRs, after implementing new features, when the user says "review this", "check this code", "is this ready?", or after any substantial implementation work. Always pick the right specialty checklist based on what changed.
---

# Engineering Review

Structured code review against Tumai-specific checklists. Picks the right specialty based on what files changed, runs every check, produces a graded report.

## When to use

- Before merging any PR
- After implementing a new automation, executor, or UI feature
- When asked to "review", "check", or "is this ready?"
- After substantial work on any package or app

## Procedure

### Step 1: Detect what changed

```bash
# What files changed vs main (for PRs) or vs last commit (for local work)
git diff --name-only HEAD~1 2>/dev/null || git diff --name-only --cached
```

### Step 2: Pick the right checklist(s)

| Files changed | Checklist to use |
|---------------|-----------------|
| `packages/automations/**` | `checklists/automation-contracts.md` |
| `packages/runtime/**` | `checklists/runtime-safety.md` |
| `apps/studio/src/**` | `checklists/frontend-ui.md` |
| `.claude/**, .env, package.json, .github/**` | `checklists/security.md` |
| `apps/**, packages/**, monorepo structure` | `checklists/architecture.md` |

If changes span multiple areas, run ALL matching checklists.

### Step 3: Run the checklist

Read the matching checklist file(s) from `checklists/` directory (relative to this skill).
For each item, check pass/fail with evidence.

### Step 4: Produce the report

```
ENGINEERING REVIEW
==================
Scope: {what was reviewed}
Checklist(s): {which ones ran}
Date: {date}

## Results

| # | Check | Status | Evidence |
|---|-------|--------|----------|
| 1 | ... | ✓ PASS | ... |
| 2 | ... | ✗ FAIL | ... |
| 3 | ... | ⚠ WARN | ... |

## Summary
- Passed: N/M
- Failed: N (list each with fix)
- Warnings: N

## Verdict: READY / NEEDS FIXES / BLOCKED
```

### Step 5: If NEEDS FIXES, list each fix with file and line

Don't just say "fix this" — show exactly what to change.
